Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42786 )
Change subject: mb/amd: Add Pollock CRB Cereme as Mandolin variant
......................................................................
Patch Set 21:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42786/21/src/mainboard/amd/mandolin...
File src/mainboard/amd/mandolin/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/42786/21/src/mainboard/amd/mandolin...
PS21, Line 13: # TODO: provide separate APCB for Cereme
it should be, but the APCB from mandolin also works for cereme. […]
https://review.coreboot.org/c/blobs/+/45657 will provide the correct APCB
https://review.coreboot.org/c/coreboot/+/42786/21/src/mainboard/amd/mandolin...
File src/mainboard/amd/mandolin/variants/cereme/devicetree.cb:
PS21:
the SPI settings are still missing; same for Mandolin. didn't run into that, since i use an EM100 for my tests
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42786
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ief8a05b0a360563d26a81941720b78014feb0d25
Gerrit-Change-Number: 42786
Gerrit-PatchSet: 21
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Matt Papageorge
matthewpapa07@gmail.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 23 Sep 2020 15:32:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment