Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32487 )
Change subject: mainboard/google/hatch: Enable PEN_EJECT_L as wake & notify source. ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/#/c/32487/1/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/baseboard/gpio.c:
https://review.coreboot.org/#/c/32487/1/src/mainboard/google/hatch/variants/... PS1, Line 34: INVERT Why are we applying the invert here?
https://review.coreboot.org/#/c/32487/1/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/hatch/overridetree.cb:
https://review.coreboot.org/#/c/32487/1/src/mainboard/google/hatch/variants/... PS1, Line 90: GPE0_DW0_8 GPE0_DW0_08
https://review.coreboot.org/#/c/32487/1/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/hatch_whl/overridetree.cb:
https://review.coreboot.org/#/c/32487/1/src/mainboard/google/hatch/variants/... PS1, Line 74: ACPI_GPIO_IRQ_EDGE_LOW This should be active high right? i.e. when pen is inserted, the signal would be read as high? some discussion here: https://review.coreboot.org/c/coreboot/+/31815