3 comments:
File src/mainboard/google/hatch/variants/baseboard/gpio.c:
Patch Set #1, Line 34: INVERT
Why are we applying the invert here?
File src/mainboard/google/hatch/variants/hatch/overridetree.cb:
Patch Set #1, Line 90: GPE0_DW0_8
GPE0_DW0_08
File src/mainboard/google/hatch/variants/hatch_whl/overridetree.cb:
Patch Set #1, Line 74: ACPI_GPIO_IRQ_EDGE_LOW
This should be active high right? i.e. when pen is inserted, the signal would be read as high? some discussion here: https://review.coreboot.org/c/coreboot/+/31815
To view, visit change 32487. To unsubscribe, or for help writing mail filters, visit settings.