Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45222 )
Change subject: soc/amd/picasso: Moves APCB generation out of picasso
......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45222/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/45222/2//COMMIT_MSG@7
PS2, Line 7: Moves
Please use imperative mood.
Move …
https://review.coreboot.org/c/coreboot/+/45222/2//COMMIT_MSG@9
PS2, Line 9: Moved APCB generation out of the picasso makefile and into the mainboard
Normally present tense is used in summaries.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45222
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib85ad94e515f2ffad58aafe06c1f1d4043e9303c
Gerrit-Change-Number: 45222
Gerrit-PatchSet: 2
Gerrit-Owner: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Martin Roth
martin.roth@tinkermill.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 10 Sep 2020 15:43:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment