Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32862 )
Change subject: device_tree: Add version checks
......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/#/c/32862/5/src/include/device_tree.h
File src/include/device_tree.h:
https://review.coreboot.org/#/c/32862/5/src/include/device_tree.h@36
PS5, Line 36: last_comp_version
isn't the old name better?
https://review.coreboot.org/#/c/32862/5/src/lib/device_tree.c
File src/lib/device_tree.c:
https://review.coreboot.org/#/c/32862/5/src/lib/device_tree.c@237
PS5, Line 237: printk(BIOS_DEBUG,
: "NOTE: FDT version %u too new, should add support!\n",
: version);
so we're not failing or skip?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32862
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I06c112f540213c8db7c2455c2e8a4e8e4f337b78
Gerrit-Change-Number: 32862
Gerrit-PatchSet: 5
Gerrit-Owner: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 23 May 2019 00:54:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment