Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37936 )
Change subject: mb/google/hatch/akemi: modify DPTF parameters for new FAN ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37936/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/akemi/include/variant/acpi/dptf.asl:
https://review.coreboot.org/c/coreboot/+/37936/1/src/mainboard/google/hatch/... PS1, Line 75: Package () {85, 0xFFFFFFFF, 5500, 180, 1800}, : Package () {79, 0xFFFFFFFF, 5400, 170, 1700}, : Package () {76, 0xFFFFFFFF, 5300, 165, 1650}, : Package () {73, 0xFFFFFFFF, 5200, 160, 1600}, : Package () {70, 0xFFFFFFFF, 5100, 155, 1550}, : Package () {68, 0xFFFFFFFF, 5000, 150, 1500}, : Package () {65, 0xFFFFFFFF, 4900, 145, 1450}, : Package () {62, 0xFFFFFFFF, 4800, 140, 1400}, : Package () {60, 0xFFFFFFFF, 4700, 135, 1350}, : Package () {58, 0xFFFFFFFF, 4600, 130, 1300}, : Package () {55, 0xFFFFFFFF, 4500, 120, 1200}, : Package () {53, 0xFFFFFFFF, 4400, 110, 1100}, : Package () {51, 0xFFFFFFFF, 4300, 100, 1000}, : Package () {49, 0xFFFFFFFF, 4200, 95, 950}, : Package () {47, 0xFFFFFFFF, 4100, 80, 800}, : Package () {46, 0xFFFFFFFF, 4000, 70, 700}, : Package () {45, 0xFFFFFFFF, 3900, 60, 600}, : Package () {43, 0xFFFFFFFF, 3800, 55, 550}, : Package () {42, 0xFFFFFFFF, 3700, 50, 500}, : Package () {40, 0xFFFFFFFF, 3600, 35, 350}, : Package () {38, 0xFFFFFFFF, 3500, 30, 300}, : Package () {36, 0xFFFFFFFF, 3400, 25, 250}, : Package () {33, 0xFFFFFFFF, 3300, 20, 200}, : Package () {32, 0xFFFFFFFF, 3200, 15, 150}, : Package () {31, 0xFFFFFFFF, 3100, 10, 100}, : Package () {30, 0xFFFFFFFF, 3000, 5, 50}, : Package () {0, 0xFFFFFFFF, 0, 0, 0} Just noting that this is a really fine-grained table. Are you worried at all about jitter in the temperature causing the fans to change speeds very often?