Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42094 )
Change subject: amd/00730F01: Clean the Microcode updating. ......................................................................
Patch Set 4:
(3 comments)
https://review.coreboot.org/c/coreboot/+/42094/4/src/cpu/amd/pi/00730F01/upd... File src/cpu/amd/pi/00730F01/update_microcode.c:
https://review.coreboot.org/c/coreboot/+/42094/4/src/cpu/amd/pi/00730F01/upd... PS4, Line 104: m = (struct microcode *)c; : : if (m->processor_rev_id == equivalent_processor_rev_id) : apply_microcode_patch(m); does cpu_microcode_blob.bin only contain exactly one microcode update? if not, then this is likely a bug, since the code only lookes at the first one in the microcode binary
https://review.coreboot.org/c/coreboot/+/42094/4/src/cpu/amd/pi/00730F01/upd... PS4, Line 116: if (equivalent_processor_rev_id == 0) { : printk(BIOS_DEBUG, "microcode: rev id not found. Skipping microcode patch!\n"); : return; : } since no lookup table is used any more, this check can be removed
https://review.coreboot.org/c/coreboot/+/42094/4/src/cpu/amd/pi/00730F01/upd... PS4, Line 124: BIOS_DEBUG BIOS_WARNING maybe? should be at least BIOS_INFO though