Nikolai Vyssotski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47545 )
Change subject: mb/amd/mandolin: Add decode range for LPC debug card
......................................................................
Patch Set 6:
(2 comments)
https://review.coreboot.org/c/coreboot/+/47545/3//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/47545/3//COMMIT_MSG@9
PS3, Line 9: Newer
oh. […]
Done
https://review.coreboot.org/c/coreboot/+/47545/3/src/mainboard/amd/mandolin/...
File src/mainboard/amd/mandolin/bootblock.c:
https://review.coreboot.org/c/coreboot/+/47545/3/src/mainboard/amd/mandolin/...
PS3, Line 15: RANGE
i'd call it _BASE instead of _RANGE
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47545
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I103c61f21f13970dfa3b9a788b29964e478fb84c
Gerrit-Change-Number: 47545
Gerrit-PatchSet: 6
Gerrit-Owner: Nikolai Vyssotski
nikolai.vyssotski@amd.corp-partner.google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Comment-Date: Mon, 23 Nov 2020 19:01:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Marshall Dawson
marshalldawson3rd@gmail.com
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment