HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33964 )
Change subject: cpu/x86/pae/pgtbl: Use CRx_TYPE type for CRx ......................................................................
Patch Set 3:
I've started this because CRx_TYPE is defined as uint64_t if we have x86_64 and uint32_t if x86_32.
Your are right, I got only those warning:
src/cpu/x86/pae/pgtbl.c 153:21: warning: format '%p' expects argument of type 'void *', but argument 4 has type 'struct pg_table *' [-Wformat=] src/cpu/x86/pae/pgtbl.c 153:41: note: format string is defined here src/cpu/x86/pae/pgtbl.c 204:22: note: in expansion of macro 'MIN' src/cpu/x86/pae/pgtbl.c 204:40: warning: conversion to 'long unsigned int' from 'ssize_t' {aka 'long int'} may change the sign of the result [-Wsign-conversion] src/cpu/x86/pae/pgtbl.c 210:17: warning: conversion from 'long long unsigned int' to 'uint32_t' {aka 'unsigned int'} may change value [-Wconversion] src/cpu/x86/pae/pgtbl.c 211:17: warning: conversion from 'uint64_t' {aka 'long long unsigned int'} to 'uint32_t' {aka 'unsigned int'} may change value [-Wconversion] src/cpu/x86/pae/pgtbl.c 217:15: warning: conversion to 'uint64_t' {aka 'long long unsigned int'} from 'ssize_t' {aka 'long int'} may change the sign of the result [-Wsign-conversion] src/cpu/x86/pae/pgtbl.c 217:46: warning: conversion to 'long unsigned int' from 'ssize_t' {aka 'long int'} may change the sign of the result [-Wsign-conversion] src/cpu/x86/pae/pgtbl.c 219:20: warning: pointer of type 'void *' used in arithmetic [-Wpointer-arith] src/cpu/x86/pae/pgtbl.c 271:21: warning: conversion to 'uint32_t' {aka 'unsigned int'} from 'int' may change the sign of the result [-Wsign-conversion] src/cpu/x86/pae/pgtbl.c 279:6: warning: conversion to 'long unsigned int' from 'int' may change the sign of the result [-Wsign-conversion] src/cpu/x86/pae/pgtbl.c 301:10: warning: unsigned conversion from 'int' to 'unsigned int' changes value from '-2049' to '4294965247' [-Wsign-conversion] src/cpu/x86/pae/pgtbl.c 309:11: warning: conversion from 'uint64_t' {aka 'long long unsigned int'} to 'unsigned int' may change value [-Wconversion] src/cpu/x86/pae/pgtbl.c 310:11: warning: conversion from 'uint64_t' {aka 'long long unsigned int'} to 'unsigned int' may change value [-Wconversion] src/cpu/x86/pae/pgtbl.c 369:39: note: in expansion of macro 'REGION_SIZE' src/cpu/x86/pae/pgtbl.c 374:43: note: in expansion of macro 'REGION_SIZE' src/cpu/x86/pae/pgtbl.c 517:14: note: in expansion of macro 'MIN' src/cpu/x86/pae/pgtbl.c 531:23: warning: unsigned conversion from 'int' to 'uint32_t' {aka 'unsigned int'} changes value from '-2147483648' to '2147483648' [-Wsign-conversion] src/cpu/x86/pae/pgtbl.c 98:6: warning: unsigned conversion from 'int' to 'uint32_t' {aka 'unsigned int'} changes value from '-2147483648' to '2147483648' [-Wsign-conversion]
so, maybe I have to drop this change