Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35303 )
Change subject: mb/google/drallion: Enable 360 sensor detection ......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35303/6/src/mainboard/google/dralli... File src/mainboard/google/drallion/romstage.c:
https://review.coreboot.org/c/coreboot/+/35303/6/src/mainboard/google/dralli... PS6, Line 61: #if CONFIG(BOARD_GOOGLE_DRALLION)
- Does this mean that it will be OK to declare variant_memory_init_params as __weak? […]
Use of __weak should be totally fine. That is how we are handling variant_* specific functions in other mainboards. Example from Hatch: https://review.coreboot.org/cgit/coreboot.git/tree/src/mainboard/google/hatc...
https://review.coreboot.org/cgit/coreboot.git/tree/src/mainboard/google/hatc...