1 comment:
File src/mainboard/google/drallion/romstage.c:
Patch Set #6, Line 61: #if CONFIG(BOARD_GOOGLE_DRALLION)
- Does this mean that it will be OK to declare variant_memory_init_params as __weak? […]
Use of __weak should be totally fine. That is how we are handling variant_* specific functions in other mainboards. Example from Hatch:
https://review.coreboot.org/cgit/coreboot.git/tree/src/mainboard/google/hatch/variants/baseboard/include/baseboard/variants.h?id=refs/heads/master
https://review.coreboot.org/cgit/coreboot.git/tree/src/mainboard/google/hatch/variants/baseboard/gpio.c?id=refs/heads/master#n440
To view, visit change 35303. To unsubscribe, or for help writing mail filters, visit settings.