Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31112 )
Change subject: soc/intel/common/rtc: Enable RTC in common code RTC ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/31112/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/31112/1//COMMIT_MSG@7 PS1, Line 7: if
in, maybe?
Done
https://review.coreboot.org/#/c/31112/1//COMMIT_MSG@9 PS1, Line 9: Intel RTC common code driver need to turn on RTC itself.
Maybe mention that this adds RTC for CNL/ICL.
Done