Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34752 )
Change subject: arch/x86: Attempt to boot without postcar stage/phase
......................................................................
Patch Set 2:
Guys, remember to remain civil.
Yes, open source software is relatively open to experimentation.
No, experimentation isn't immune from having to explain itself.
Yes, Intel folks talking up the benefits of open source exploration sounds stale given FSP (where is the source, given that open source is so great?)
No, that discussion doesn't belong here.
As far as experiments having to explain themselves:
The postcar phase was only recently introduced, and it helped create clearer boundaries _especially_ in light of FSP (that is, without the FSP1/FSP2 saga, we might have never introduced a postcar stage). Messing with that again needs a better argument than "we want to mess with FSP some more and coreboot makes that inconvenient".
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34752
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibc88e6727b2fa692585dffe576e69f6d4d0b349d
Gerrit-Change-Number: 34752
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 06 Aug 2019 17:53:52 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment