Attention is currently required from: Arthur Heymans, Felix Held, Martin Roth.
Varshit Pandya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76507?usp=email )
Change subject: soc/amd/genoa: Enable uart ......................................................................
Patch Set 10:
(5 comments)
Patchset:
PS4:
there was some dependency between the smi and gpio, but i don't remember which way around. […]
Done
File src/mainboard/amd/onyx/Kconfig:
https://review.coreboot.org/c/coreboot/+/76507/comment/7127ce13_5bb08252 : PS7, Line 1: if BOARD_AMD_ONYX
can this file be moved to a separate commit from the genoa code?
Done
File src/soc/amd/genoa/Kconfig:
PS2:
looks like the amd soc code isn't using this directly, but it looks like that the seabios payload us […]
Done
https://review.coreboot.org/c/coreboot/+/76507/comment/6e4be17e_07635cbe : PS2, Line 15: select SOC_AMD_COMMON_BLOCK_CPUFREQ_FAM17H_19H
duplicate
Done
File src/soc/amd/genoa/include/soc/smi.h:
PS4:
beware that this one is a bit tricky to review; i think you'll need to look at different groups of r […]
Done