[coreboot-gerrit] Change in ...coreboot[master]: nb/intel/nehalem: Die if no memory ranks found

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33403 )

Change subject: nb/intel/nehalem: Die if no memory ranks found
......................................................................

Patch Set 1: Code-Review+1
> Patch Set 1: Code-Review+2
>
> Replacing an unhandled exception (division by zero) with a die()
> can't break anything more than it is already :)

Sure, why not? If things happen to break later, it probably means the nehalem code would need some cleanup. I will take care of it when I try porting my stack of half a dozen nehalem laptops.

I was thinking of using a continue statement, but hell knows if the code will break later...