Bill XIE has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39906 )
Change subject: drivers/pc80/rtc: Always load cmos.default if measured boot is enabled
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39906/5/src/drivers/pc80/rtc/option...
File src/drivers/pc80/rtc/option.c:
https://review.coreboot.org/c/coreboot/+/39906/5/src/drivers/pc80/rtc/option...
PS5, Line 246:
Done as you wish, but I believe we do not need such complexity just to save a file loading which in coreboot is just getting a pointer to it.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39906
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If6ea0d1cbaa7d96f7dea7e77b7548ca2b30efe9e
Gerrit-Change-Number: 39906
Gerrit-PatchSet: 5
Gerrit-Owner: Bill XIE
persmule@hardenedlinux.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
siro@das-labor.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 30 Mar 2020 11:29:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment