Marc Jones has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47253 )
Change subject: soc/intel/xeon_sp: Fix generating DMAR IOAPIC
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47253/1/src/soc/intel/xeon_sp/nb_ac...
File src/soc/intel/xeon_sp/nb_acpi.c:
https://review.coreboot.org/c/coreboot/+/47253/1/src/soc/intel/xeon_sp/nb_ac...
PS1, Line 183: static int stack_to_ioapic_idx(const IIO_STACKS stack)
I think that this needs to go in soc_util.c to support each cpu. cpx and ksx have different number of stacks.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47253
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9b6da491f8d5d1004864c9d704578c3b060809cb
Gerrit-Change-Number: 47253
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 05 Nov 2020 22:58:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment