Attention is currently required from: Subrata Banik.
Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61500 )
Change subject: mb/google/brya: Lock TPM IRQ pin in brask and brya baseboards
......................................................................
Patch Set 6: Code-Review+2
(1 comment)
File src/mainboard/google/brya/variants/baseboard/brask/gpio.c:
https://review.coreboot.org/c/coreboot/+/61500/comment/b03466a0_8dd376b7
PS6, Line 371: PAD_CFG_GPI_APIC(GPP_A13, NONE, PLTRST, LEVEL, INVERT),
Is the thinking here that there's no need to set these as LOCK_CONFIG in the early table given they won't get locked until closer to the end of coreboot anyway, so the definitions in the main table will surfice?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61500
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icfc251152278c59f9a94b84fcd8c6d36c26bff62
Gerrit-Change-Number: 61500
Gerrit-PatchSet: 6
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Comment-Date: Wed, 02 Feb 2022 20:48:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment