Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38849 )
Change subject: soc/intel/common: Update Jasperlake Device IDs
......................................................................
Patch Set 9:
(3 comments)
https://review.coreboot.org/c/coreboot/+/38849/6//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/38849/6//COMMIT_MSG@7
PS6, Line 7: Jasperlake
Jasper Lake
Please address this comment as well.
https://review.coreboot.org/c/coreboot/+/38849/5/src/include/device/pci_ids....
File src/include/device/pci_ids.h:
https://review.coreboot.org/c/coreboot/+/38849/5/src/include/device/pci_ids....
PS5, Line 3394: JSL
The CPU core IPs use JSL and the PCH IPs use JSP. But thanks for the finding. […]
Done
https://review.coreboot.org/c/coreboot/+/38849/5/src/include/device/pci_ids....
PS5, Line 3453: #define PCI_DEVICE_ID_INTEL_JSL_EHL 0x4532
: #define PCI_DEVICE_ID_INTEL_EHL_ID_1 0x4510
Yes, these IDs have got nothing to do with JasperLake. They are EHL specific.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38849
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2c9ec1eb4236184b981d99250f263172c82f7117
Gerrit-Change-Number: 38849
Gerrit-PatchSet: 9
Gerrit-Owner: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Varshit B Pandya
varshit.b.pandya@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 14 Feb 2020 17:54:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Comment-In-Reply-To: Meera Ravindranath
meera.ravindranath@intel.com
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment