John Zhao has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44185 )
Change subject: drivers/usb: Avoid value overwritten before its usage ......................................................................
drivers/usb: Avoid value overwritten before its usage
Coverity detects that value assigned to variable "ret" is overwritten before it is used. Fix the issue by returning right value.
Found-by: Coverity CID 1255942, 1241836 TEST=None
Signed-off-by: John Zhao john.zhao@intel.com Change-Id: I2e1fb5400ff64c6178bb30601896780f8d67b5c6 --- M src/drivers/usb/ehci_debug.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/44185/1
diff --git a/src/drivers/usb/ehci_debug.c b/src/drivers/usb/ehci_debug.c index 5998172..3a52cca 100644 --- a/src/drivers/usb/ehci_debug.c +++ b/src/drivers/usb/ehci_debug.c @@ -581,7 +581,7 @@ ctrl = read32(&ehci_debug->control); ctrl &= ~(DBGP_CLAIM | DBGP_OUT); write32(&ehci_debug->control, ctrl); - //return ret; + return ret;
next_debug_port: if (CONFIG_USBDEBUG_DEFAULT_PORT == 0) {