Lean Sheng Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36221 )
Change subject: Add configurable ramstage support for minimal PCI scanning ......................................................................
Patch Set 9: Code-Review+1
Patch Set 9:
I share Kyösti's concerns how this could be compatible to our code for real hardware targets. Existing platform code relies heavily on the VID/DID of PCI devices, that are never read with this approach. So what should it be, should we hide the minimal scanning option for all boards but those that are confirmed to be fully compatible? Should we add a big fat warning, that this is experimental and will break 90% of our ramstage code (and hence, nobody should complain or even try to fix it)? Should we remodel all of coreboot so we rely less on PCI and do things more in a blob-style manner?
Without knowing even a coarse plan how to adapt this to exis- ting hardware support, I really don't see how this is a step forward. At least a hardware PoC with extensive Linux tests (not just, it boots) would be nice. Also, if this requires changes to the OS, do we expect upstream Linux, for instance, to follow?
Hi Nico, While I respect your technical expertise, I cannot fathom your sentiments on this case. Do you mean that every changes in open source should be vigorously validated with most platforms, and require a coarse plan for implementation? From my understanding, the success and sustainability of open source relies on its openness to encourage and embrace changes no matter how big or small. You should be even more understanding on this as I saw your countless changes everywhere, still we happily accept your inputs even it breaks our codes some times. With that being said, this patch is providing a forefront idea for us to further improve the flexibility of coreboot. Of course, we can't expect it to be perfect, but anyone can take it and experiment with it and further improving it. I can foresee how it will make our codes to run more dynamically, and it will also eventually push changes to the linux side as well.
I can't make you to change your mind, but i am sure you know what needs to be done if we want coreboot to continue evolves into much greater form.