Josie Nordrum has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44157 )
Change subject: mb/google/zork: Make SW changes for HP_INT_ODL in schematic v3.6 ......................................................................
Patch Set 3:
(7 comments)
https://review.coreboot.org/c/coreboot/+/44157/1/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/baseboard/gpio_baseboard_dalboz.c:
https://review.coreboot.org/c/coreboot/+/44157/1/src/mainboard/google/zork/v... PS1, Line 97: PAD_GPI(GPIO_84),
Just realized that this will have to be: PAD_GPI(GPIO_84, PULL_NONE) […]
Done
https://review.coreboot.org/c/coreboot/+/44157/1/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/baseboard/gpio_baseboard_trembyle.c:
https://review.coreboot.org/c/coreboot/+/44157/1/src/mainboard/google/zork/v... PS1, Line 68: unused
Comment needs update too.
Done
https://review.coreboot.org/c/coreboot/+/44157/1/src/mainboard/google/zork/v... PS1, Line 69: PAD_GPI(GPIO_29),
Same here: PAD_GPI(GPIO_29, PULL_NONE),
Done
https://review.coreboot.org/c/coreboot/+/44157/1/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/baseboard/ramstage_common.c:
https://review.coreboot.org/c/coreboot/+/44157/1/src/mainboard/google/zork/v... PS1, Line 7: #include <drivers/amd/i2s_machine_dev/chip.h>
You will also need #include <drivers/i2c/generic/chip.h> for struct drivers_i2c_generic_config.
Done
https://review.coreboot.org/c/coreboot/+/44157/1/src/mainboard/google/zork/v... PS1, Line 16: rt5682_path
This can be moved to live within update_hp_int_odl() since it is not required outside that function.
Done
https://review.coreboot.org/c/coreboot/+/44157/1/src/mainboard/google/zork/v... PS1, Line 37: void
static void
Done
https://review.coreboot.org/c/coreboot/+/44157/1/src/mainboard/google/zork/v... PS1, Line 60: GPIO_62
Looks like GPIO_62 macro is not provided by SoC (probably because it is not a pad that can be config […]
Done