[coreboot-gerrit] Change in ...coreboot[master]: soc/intel/braswell/acpi/lpc.asl: Allocate used ROM size only

[Frans Hendriks (Code Review)]

Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31822 )

Change subject: soc/intel/braswell/acpi/lpc.asl: Allocate used ROM size only
......................................................................

Patch Set 4:
> Patch Set 4:
>
> This looks like a severe compiler bug, please don't
> just work around it. It seems the compiler precalcu-
> lates the correct numbers, but places 0s into the
> Memory32Fixed resource and the numbers after it,
> amidst the bytestream:
>
> Buffer that contains 14B:
>   11 11 0a 0e
>   The memory range filled with 0s:
>   86 09 00 00 00 00 00 00 00 00 00 00
>   End Tag:
>   79 00
>   After the buffer our numbers:
>   00 00 80 ff 00 00 80 00
>
> Please let me know if you don't want to check if the
> issue persists upstream and report this.

(How did you generate this bytestream?)

I would expect this behavoir. 
Compiler will create RBUF with 0s. Run-time this buffer will be filled.

Can you clarify why it looks like a bug?