build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34545 )
Change subject: SPM: mt8183: support spm suspend in coreboot ......................................................................
Patch Set 1:
(7 comments)
https://review.coreboot.org/c/coreboot/+/34545/1/src/soc/mediatek/mt8183/inc... File src/soc/mediatek/mt8183/include/soc/spm_init.h:
https://review.coreboot.org/c/coreboot/+/34545/1/src/soc/mediatek/mt8183/inc... PS1, Line 946: #define SEPERATE_PHY_PWR_SEL_LSB (1U << 23) /* 1b */ 'SEPERATE' may be misspelled - perhaps 'SEPARATE'?
https://review.coreboot.org/c/coreboot/+/34545/1/src/soc/mediatek/mt8183/spm... File src/soc/mediatek/mt8183/spm.c:
https://review.coreboot.org/c/coreboot/+/34545/1/src/soc/mediatek/mt8183/spm... PS1, Line 168: printk(BIOS_INFO, "spm_kick_im_to_fetch: ptr = 0x%x\n", ptr); Prefer using '"%s...", __func__' to using 'spm_kick_im_to_fetch', this function's name, in a string
https://review.coreboot.org/c/coreboot/+/34545/1/src/soc/mediatek/mt8183/spm... PS1, Line 169: printk(BIOS_INFO, "spm_kick_im_to_fetch: len = %d\n", len); Prefer using '"%s...", __func__' to using 'spm_kick_im_to_fetch', this function's name, in a string
https://review.coreboot.org/c/coreboot/+/34545/1/src/soc/mediatek/mt8183/spm... PS1, Line 208: static const char *dyna_load_pcm_path[] = { static const char * array should probably be static const char * const
https://review.coreboot.org/c/coreboot/+/34545/1/src/soc/mediatek/mt8183/spm... PS1, Line 276: printk(BIOS_INFO, "SPM spm_kick_pcm_to_run\n"); Prefer using '"%s...", __func__' to using 'spm_kick_pcm_to_run', this function's name, in a string
https://review.coreboot.org/c/coreboot/+/34545/1/src/soc/mediatek/mt8183/spm... PS1, Line 288: printk(BIOS_INFO, "SPM spm_kick_pcm_to_run done\n"); Prefer using '"%s...", __func__' to using 'spm_kick_pcm_to_run', this function's name, in a string
https://review.coreboot.org/c/coreboot/+/34545/1/src/soc/mediatek/mt8183/spm... PS1, Line 320: printk(BIOS_INFO, "SPM spm_init done\n"); Prefer using '"%s...", __func__' to using 'spm_init', this function's name, in a string