Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43004 )
Change subject: soc/intel/xeon_sp: Add RTC failure checking ......................................................................
Patch Set 2:
(4 comments)
https://review.coreboot.org/c/coreboot/+/43004/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/43004/2//COMMIT_MSG@8 PS2, Line 8: Please add some explanation of the flow. Here we are checking these error conditions: RTC battery is removed; RTC battery is dead.
https://review.coreboot.org/c/coreboot/+/43004/2/src/soc/intel/xeon_sp/pmuti... File src/soc/intel/xeon_sp/pmutil.c:
https://review.coreboot.org/c/coreboot/+/43004/2/src/soc/intel/xeon_sp/pmuti... PS2, Line 16: return !!(gen_pmcon_b & RTC_BATTERY_DEAD); If RTC battery is dead, let's print an error message.
https://review.coreboot.org/c/coreboot/+/43004/2/src/soc/intel/xeon_sp/pmuti... PS2, Line 24: __func__, (pmcon_b&0x04)?"removed":"inserted", pmcon_b); If RTC battery is removed, let's print an error message. Otherwise, a SPEW message.
https://review.coreboot.org/c/coreboot/+/43004/2/src/soc/intel/xeon_sp/romst... File src/soc/intel/xeon_sp/romstage.c:
https://review.coreboot.org/c/coreboot/+/43004/2/src/soc/intel/xeon_sp/romst... PS2, Line 21: if (soc_get_rtc_failed()) If RTC failed, let's print an error message.