Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32526 )
Change subject: Makefile.inc: Update fsp submodule if CONFIG_USE_BLOBS
......................................................................
Patch Set 1:
Patrick, any feelings about this? IIRC, you added the
first `ifeq (...FSP...)` here. If preferred we can also
only check it out when any FSP board is selected. Then
we could add a Kconfig for that (probably better than
yet another `ifeq`).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32526
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If07d55828a1863623e04a4ecdd1514c3cb6d9c11
Gerrit-Change-Number: 32526
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 01 May 2019 19:05:51 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment