[coreboot-gerrit] Change in coreboot[master]: soc/intel/cannonlake: Move GPIO PM configuration to soc level

[EricR Lai (Code Review)]

EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37685 )

Change subject: soc/intel/cannonlake: Move GPIO PM configuration to soc level
......................................................................

Patch Set 10:
> Patch Set 10:
> > Patch Set 10:
> > > Patch Set 10:
> > > > Patch Set 10:
> > > > > Patch Set 10:
> > > > >
> > > > > (1 comment)
> > > >
> > > > @Kane, if you have Sarien on hand. You can check the KB backlight or light of power button is off or not after enter s0ix. If DSM is not called, the light will keep on.
> > >
> > > i'm using hatch, i added debug code and enable acpi debug in kernel.
> > > The DSM s0ix exit/entry functions are only called after i powerd_dbus_suspend.
> >
> > @Kane, Lid, idle, powerd, echo freeze all can work on Sarien. I will check Hatch later. I print ACPI debug with echo 1 > /sys/module/acpi/parameters/aml_debug_output
>
> when you say idle, you simply just idle/screen on and then  Function 5 - Low Power S0 Entry Notification and Function 6 - Low Power S0 Exit Notification got called?

Yes, this is called by kernel even CPU is not go into C10.