Attention is currently required from: Tim Wawrzynczak, Sridhar Siricilla, Werner Zeh, Patrick Rudolph. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61520 )
Change subject: soc/intel/common/cse: Function performs global reset lock ......................................................................
Patch Set 7:
(6 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/61520/comment/ce9a5a7b_4d2326b2 PS5, Line 9: perform the required CSE : lock configuration
nit: controls the global reset lock configuration
Ack
File src/soc/intel/common/block/cse/cse.c:
https://review.coreboot.org/c/coreboot/+/61520/comment/1f872067_71fc0a37 PS5, Line 1012: cse_lock_config
nit: cse_control_global_reset_lock?
Ack
https://review.coreboot.org/c/coreboot/+/61520/comment/23f94e17_6c4ea6f2 PS5, Line 1014: /*
hmm, correct, my mistake, it should remain locked always irrespective of HFSTS1 [4] state in case o […]
Ack
File src/soc/intel/common/block/cse/cse.c:
https://review.coreboot.org/c/coreboot/+/61520/comment/301c0800_a1976e6a PS6, Line 1018: (cse_is_hfs1_com_normal() || cse_is_hfs1_com_soft_temp_disable())
**When CSE is always in bad state then how can one follow #2 so the only way is #1 hence, we shou […]
Done
https://review.coreboot.org/c/coreboot/+/61520/comment/8c8df5bc_76be74ba PS6, Line 1020: /* : * Make sure payload/OS can't trigger global reset. : * BIOS must also ensure that CF9GR is cleared and locked (Bit31 of ETR3) : * prior to transferring control to the OS. : *
nit: Can this be moved to line#1017?
Ack
File src/soc/intel/common/block/include/intelblocks/cse.h:
https://review.coreboot.org/c/coreboot/+/61520/comment/33b3195c_7bda242c PS4, Line 501: Function performs
nit: Performs
Ack