You-Cheng Syu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30331 )
Change subject: google/kukui: Move some initialization from bootblock to verstage.
......................................................................
Patch Set 11:
(2 comments)
https://review.coreboot.org/#/c/30331/10/src/mainboard/google/kukui/Makefile...
File src/mainboard/google/kukui/Makefile.inc:
https://review.coreboot.org/#/c/30331/10/src/mainboard/google/kukui/Makefile...
PS10, Line 10: mainboard.c
Usually mainboard. […]
Done
https://review.coreboot.org/#/c/30331/10/src/mainboard/google/kukui/mainboar...
File src/mainboard/google/kukui/mainboard.c:
https://review.coreboot.org/#/c/30331/10/src/mainboard/google/kukui/mainboar...
PS10, Line 70: /* Turn on real eMMC. */
: gpio_output(BOOTBLOCK_EN_L, 1);
Can we move this to before mt8183_early_init, or at least before setup_chromeos_gpios? And change th […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30331
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9968d88c54283ef334d1ab975086d4adb3363bd6
Gerrit-Change-Number: 30331
Gerrit-PatchSet: 11
Gerrit-Owner: You-Cheng Syu
youcheng@google.com
Gerrit-Reviewer: Chun-ta Lin
itspeter@google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Tristan Hsieh
tristan.shieh@mediatek.com
Gerrit-Reviewer: You-Cheng Syu
youcheng@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Comment-Date: Thu, 24 Jan 2019 08:43:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hung-Te Lin
hungte@chromium.org
Gerrit-MessageType: comment