[coreboot-gerrit] Change in coreboot[master]: superio/nuvoton: Only set bit 7 of global CR 0x2a for COM A

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46286 )

Change subject: superio/nuvoton: Only set bit 7 of global CR 0x2a for COM A
......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/46286/3/src/superio/nuvoton/common/... 
File src/superio/nuvoton/common/early_serial.c:

https://review.coreboot.org/c/coreboot/+/46286/3/src/superio/nuvoton/common/... 
PS3, Line 62: 		pnp_write_config(dev, 0x2a, 0x00);
> https://4donline.ihs.com/images/VipMasterIC/IC/NUTC/NUTC-S-A0001770713/NUTC-.... […]

Thanks.

So what you could have said is that it has the same default 0xc0 value. And
hence clearing bit 6 is spurious. I think that deserves a separate commit,
though, as it would change behavior.