Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39344 )
Change subject: soc/intel/tigerlake: Fix ACPI path for GPIO ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39344/5/src/soc/intel/tigerlake/gpi... File src/soc/intel/tigerlake/gpio_tgl.c:
https://review.coreboot.org/c/coreboot/+/39344/5/src/soc/intel/tigerlake/gpi... PS5, Line 128: No GCM2 device and group2 is not visible to kernel
Asl gets populated properly as expected but as kernel does not know about that device it simply does not do anything when the match is not found.
That sounds okay. So, basically skips it based on UID matching.
I am adding some more logs in kernel to get the exact failure.
Why do you think there is a failure?
So seems like in order to have kernel list nodes properly we need to have dummy GCM2, GCM3 in coreboot.
GCM2 exists. So, you can add real information about community 2. But I am not sure about GCM3. I don't see any information about it being available.
Even if kernel list those devices as 0,1,2,3 it would still work.
As long as the UID matches correctly and you ensure that the GPIO names used in coreboot match the kernel enumeration, things should be okay.