[coreboot-gerrit] Change in coreboot[master]: drivers/vpd: add framework to search VPD in romstage

[Hung-Te Lin (Code Review)]

Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34634 )

Change subject: drivers/vpd: add framework to search VPD in romstage
......................................................................

Patch Set 11:

(1 comment)

https://review.coreboot.org/c/coreboot/+/34634/10/src/drivers/vpd/vpd_premem... 
File src/drivers/vpd/vpd_premem.c:

https://review.coreboot.org/c/coreboot/+/34634/10/src/drivers/vpd/vpd_premem... 
PS10, Line 78: struct vpd_blob *blob = car_get_var_ptr(&g_vpd_blob);
             : 	if (!blob)
             : 		return;
> yes but I'm not sure why it can't be done automatically inside vpd_get_buffers. […]

In fact, I'm an expert in how x86 CAR works or needs (this is not required for ARM), especially if it'll share data across stages. If it won't share data, maybe we can combine the functions so that

- vpd.c: vpd_load_blob, that always reads and stores into the CAR variable.
 - vpd_cbmem: calls vpd_load_blob and save into a specific CBMEM page