[coreboot-gerrit] Change in coreboot[master]: drivers/net/r8168: Add SSDT Power Resource Methods

[Edward O'Callaghan (Code Review)]

Edward O'Callaghan has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38494 )

Change subject: drivers/net/r8168: Add SSDT Power Resource Methods
......................................................................

drivers/net/r8168: Add SSDT Power Resource Methods

Turns out when going into S0ix we want the kernel to toggle
de-assert to 0 for the ISOLATE# pin on the NIC for S0ix not
to be woken by PCIe traffic on PCH. Upon resume the ISOLATE#
pin on the NIC is then re-asserted for it to become lively
again.

BUG=b:XXX
BRANCH=none
TEST=hopeful.

Change-Id: I3ae8dc30f45f55eec23f45e7b5fbc67a4542f87d
Signed-off-by: Edward O'Callaghan 
---
M src/drivers/net/chip.h
M src/drivers/net/r8168.c
M src/mainboard/google/hatch/variants/puff/overridetree.cb
3 files changed, 42 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/38494/1

diff --git a/src/drivers/net/chip.h b/src/drivers/net/chip.h
index 430bc33..3c47c01 100644
--- a/src/drivers/net/chip.h
+++ b/src/drivers/net/chip.h
@@ -19,6 +19,29 @@
 struct drivers_net_config {
    uint16_t customized_leds;
    unsigned int wake;	/* Wake pin for ACPI _PRW */
+
+	/* Does the device have a power resource? */
+	bool has_power_resource;
+
+	/* GPIO used to take device out of reset or to put it into reset. */
+	struct acpi_gpio reset_gpio;
+	/* Delay to be inserted after device is taken out of reset. */
+	unsigned int reset_delay_ms;
+	/* Delay to be inserted after device is put into reset. */
+	unsigned int reset_off_delay_ms;
+	/* GPIO used to enable device. */
+	struct acpi_gpio enable_gpio;
+	/* Delay to be inserted after device is enabled. */
+	unsigned int enable_delay_ms;
+	/* Delay to be inserted after device is disabled. */
+	unsigned int enable_off_delay_ms;
+	/* GPIO used to stop operation of device. */
+	struct acpi_gpio stop_gpio;
+	/* Delay to be inserted after disabling stop. */
+	unsigned int stop_delay_ms;
+	/* Delay to be inserted after enabling stop. */
+	unsigned int stop_off_delay_ms;
+
    /*
     * There maybe many NIC cards in a system.
     * This parameter is for driver to identify what
diff --git a/src/drivers/net/r8168.c b/src/drivers/net/r8168.c
index 1bca879..00c4eb3 100644
--- a/src/drivers/net/r8168.c
+++ b/src/drivers/net/r8168.c
@@ -317,6 +317,22 @@
    if (dev->chip_ops)
    	acpigen_write_name_string("_DDN", dev->chip_ops->name);

+	/* Power Resource */
+	if (config->has_power_resource) {
+		const struct acpi_power_res_params power_res_params = {
+			&config->reset_gpio,
+			config->reset_delay_ms,
+			config->reset_off_delay_ms,
+			&config->enable_gpio,
+			config->enable_delay_ms,
+			config->enable_off_delay_ms,
+			&config->stop_gpio,
+			config->stop_delay_ms,
+			config->stop_off_delay_ms
+		};
+		acpi_device_add_power_res(&power_res_params);
+	}
+
    /* Address */
    address = PCI_SLOT(dev->path.pci.devfn) & 0xffff;
    address <<= 16;
diff --git a/src/mainboard/google/hatch/variants/puff/overridetree.cb b/src/mainboard/google/hatch/variants/puff/overridetree.cb
index e7fe907..671e69f 100644
--- a/src/mainboard/google/hatch/variants/puff/overridetree.cb
+++ b/src/mainboard/google/hatch/variants/puff/overridetree.cb
@@ -270,6 +270,9 @@
    	device pci 1c.0 on
    		chip drivers/net
    			register "customized_leds" = "0x05af"
+				register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_A18)"
+				register "enable_delay_ms" = "1" # 90 ns
+				register "has_power_resource" = "1"
    			device pci 00.0 on end
    		end
    	end # FSP requires func0 be enabled.