Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46930 )
Change subject: soc/mediatek/common: Add common API for loading firmwares ......................................................................
Patch Set 18:
(2 comments)
https://review.coreboot.org/c/coreboot/+/46930/17/src/soc/mediatek/common/mt... File src/soc/mediatek/common/mtlib.c:
https://review.coreboot.org/c/coreboot/+/46930/17/src/soc/mediatek/common/mt... PS17, Line 27: we release the reset pin
resetting MCU
Done
https://review.coreboot.org/c/coreboot/+/46930/17/src/soc/mediatek/common/mt... PS17, Line 30: if (reset_mcu != NULL)
if (reset_mcu)
Done