Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32850 )
Change subject: soc/intel/skylake: Add PCI Id for Kabylake DT
......................................................................
Patch Set 10:
(1 comment)
Patch Set 10:
Patch Set 9:
What is DT? If it's supposed to mean Desktop, wouldn't that be Kabylake-S?
Kabylake DT is an "entry level server" variant.
Thanks.
https://review.coreboot.org/#/c/32850/10/src/include/device/pci_ids.h
File src/include/device/pci_ids.h:
https://review.coreboot.org/#/c/32850/10/src/include/device/pci_ids.h@3085
PS10, Line 3085: #define PCI_DEVICE_ID_INTEL_KBL_ID_DT 0x591f
Now that I learned about DT, this 0x591f one is documented as S/X in
doc 567957.
Again, I guess we could have better lists if Intel would publish the
stepping and id guides.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32850
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I496b3a91f765d4fa137c32c9ee1e244803fc25d8
Gerrit-Change-Number: 32850
Gerrit-PatchSet: 10
Gerrit-Owner: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Alex Thiessen
alex.thiessen.de+coreboot@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Comment-Date: Thu, 23 May 2019 12:34:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment