10 Jun
2020
10 Jun
'20
4:08 p.m.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42033 )
Change subject: ACPI: Move redundant FADT reserved entry ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42033/3/src/acpi/acpi.c File src/acpi/acpi.c:
https://review.coreboot.org/c/coreboot/+/42033/3/src/acpi/acpi.c@1246 PS3, Line 1246: fadt->x_firmware_ctl_h = 0; Stumbled across a comment:
fadt->x_firmware_ctl_l = 0; /* Set X_FIRMWARE_CTRL only if FACS is */ fadt->x_firmware_ctl_h = 0; /* above 4GB. If X_FIRMWARE_CTRL is set, */ /* then FIRMWARE_CTRL must be zero. */
Elyes, care to review the specs?
--
To view, visit https://review.coreboot.org/c/coreboot/+/42033
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I35f66cdad6b8bedf4337aa8e5af7b0f1b53fe674
Gerrit-Change-Number: 42033
Gerrit-PatchSet: 3
Gerrit-Owner: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: 9elements QA hardwaretestrobot@gmail.com
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 10 Jun 2020 19:08:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment