[coreboot-gerrit] Change in coreboot[master]: trogdor: Move EN_PP3300_DX_EDP for Coachz

[Julius Werner (Code Review)]

Hello Douglas Anderson, Philip Chen, Bob Moragues,

I'd like you to do a code review. Please visit

https://review.coreboot.org/c/coreboot/+/45306

to review the following change.

Change subject: trogdor: Move EN_PP3300_DX_EDP for Coachz
......................................................................

trogdor: Move EN_PP3300_DX_EDP for Coachz

This patch updates the display power enable GPIO which moved from 30 to
52 for Coachz. Veterans of this project know that there's no point
trying to ask *why* this change was necessary -- the pins move in
mysterious ways and all we can do is watch and wonder. Pin 30 is now
used for a new camera reset GPIO... surely, there must have been some
excellent reason why that pin couldn't just have become pin 52 instead.

Signed-off-by: Julius Werner 
Change-Id: I00ad6a6249df66006b4f2b953a0a2449bd478f6d
---
M src/mainboard/google/trogdor/board.h
1 file changed, 2 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/45306/1

diff --git a/src/mainboard/google/trogdor/board.h b/src/mainboard/google/trogdor/board.h
index 39661b5..4d38378 100644
--- a/src/mainboard/google/trogdor/board.h
+++ b/src/mainboard/google/trogdor/board.h
@@ -16,7 +16,8 @@
 /* Display specific GPIOS */
 #define GPIO_BACKLIGHT_ENABLE  GPIO(12)
 #define GPIO_EDP_BRIDGE_ENABLE (CONFIG(TROGDOR_REV0) ? GPIO(14) : GPIO(104))
-#define GPIO_EN_PP3300_DX_EDP  (CONFIG(TROGDOR_REV0) ? GPIO(106) : GPIO(30))
+#define GPIO_EN_PP3300_DX_EDP  (CONFIG(TROGDOR_REV0) ? GPIO(106) : \
+	(CONFIG(BOARD_GOOGLE_COACHZ) ? GPIO(52) : GPIO(30)))

void setup_chromeos_gpios(void);