Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36065 )
Change subject: mainboard/google: Add initial Puff board support
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36065/2/src/mainboard/google/puff/r...
File src/mainboard/google/puff/ramstage.c:
https://review.coreboot.org/c/coreboot/+/36065/2/src/mainboard/google/puff/r...
PS2, Line 38: override_gpios);
Does this fit on one line with the new line length limit?
Hey Paul, hope you are well!?
This matches the copy from hatch so I wish not to deviate in this commit as we wish to fold it back in to hatch later. Random adhoc changes makes that harder. Style fixes should be done across the boards at the same time.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36065
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icc8b13471e6e0b8cf540c35c712089c3205a3497
Gerrit-Change-Number: 36065
Gerrit-PatchSet: 3
Gerrit-Owner: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 23 Oct 2019 12:20:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment