Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30987 )
Change subject: mb/asus: Add Asus A88XM-E FM2+ with documentation ......................................................................
Patch Set 53:
(3 comments)
https://review.coreboot.org/c/coreboot/+/30987/38/src/mainboard/asus/a88xm-e... File src/mainboard/asus/a88xm-e/Kconfig:
https://review.coreboot.org/c/coreboot/+/30987/38/src/mainboard/asus/a88xm-e... PS38, Line 39: default BOARD_ASUS_A88XM_E_DDR3_VOLT_150
Great question, I've lost in the last few commits, but I checked it back in the F2A series a dedicat […]
Done (removed the voltage setup).
https://review.coreboot.org/c/coreboot/+/30987/47/src/mainboard/asus/a88xm-e... File src/mainboard/asus/a88xm-e/Kconfig:
https://review.coreboot.org/c/coreboot/+/30987/47/src/mainboard/asus/a88xm-e... PS47, Line 55: config BOARD_ASUS_A88XM_E_DDR3_VOLT_VAL
Last time I checked the voltage was stick to 1,35 Volts. Let's remove these options.
Done (removed the voltage setup).
https://review.coreboot.org/c/coreboot/+/30987/38/src/mainboard/asus/a88xm-e... File src/mainboard/asus/a88xm-e/OemCustomize.c:
https://review.coreboot.org/c/coreboot/+/30987/38/src/mainboard/asus/a88xm-e... PS38, Line 104: * Untested: HDMI
In this case AMD is driving the D-Sub(VGA) contoller trough the FCH, while the two DP outputs are ma […]
Please investigate, which of "DP0" and "DP2" is HDMI and which is really a DVI. This could be done by removing a piece of code related to "DP0" or "DP2" and testing what got broken - HDMI or DVI.