14 Jan
2021
14 Jan
'21
5:56 p.m.
Attention is currently required from: Furquan Shaikh, Subrata Banik. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48344 )
Change subject: soc/intel/common/block/cpu: Introduce USE_CAR_NEM_ENHANCED_V3 Kconfig ......................................................................
Patch Set 2:
(1 comment)
File src/soc/intel/common/block/cpu/car/cache_as_ram.S:
https://review.coreboot.org/c/coreboot/+/48344/comment/31fd5fef_8f4597ee PS2, Line 417: USE_CAR_NEM_ENHANCED_V3
There is no _V1/_V2 anymore. I think what is different for ADL is just the 0xc85 register. […]
We should probably just add another Kconfig similar to CAR_HAS_SF_MASKS, which will program the new MSRs
--
To view, visit https://review.coreboot.org/c/coreboot/+/48344
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idb5a9ec74c50bda371c30e13aeadbb4326887fd6
Gerrit-Change-Number: 48344
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik subrata.banik@intel.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh furquan@google.com
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-CC: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Attention: Furquan Shaikh furquan@google.com
Gerrit-Attention: Subrata Banik subrata.banik@intel.com
Gerrit-Comment-Date: Thu, 14 Jan 2021 17:56:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh furquan@google.com
Gerrit-MessageType: comment