Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42521 )
Change subject: mb/pcengines/apu2: Remove gpio1_ and gpio2_ references ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42521/1/src/mainboard/pcengines/apu... File src/mainboard/pcengines/apu2/gpio_ftns.c:
https://review.coreboot.org/c/coreboot/+/42521/1/src/mainboard/pcengines/apu... PS1, Line 13: if (gpio >= 0x300) What is w/ this 0x300 check and how does it correspond 0x300? Seems we shouldn't be open coding any of this as the soc code should be bounds checking. If anything the bounds check should be on iomux_gpio. And really this code shouldn't be in here at all.
https://review.coreboot.org/c/coreboot/+/42521/1/src/mainboard/pcengines/apu... PS1, Line 16: return gpio0_read32(gpio & 0x3ff); if a single namespace for gpios is intended to be used then gpioX_read() should be dropped entirely instead of implicitly assuming the memory map is contiguous.