Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38666 )
Change subject: crossgcc: Upgrade binutils to version 2.34 ......................................................................
Patch Set 17:
(5 comments)
https://review.coreboot.org/c/coreboot/+/38666/17//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38666/17//COMMIT_MSG@9 PS17, Line 9: using Using
https://review.coreboot.org/c/coreboot/+/38666/17//COMMIT_MSG@9 PS17, Line 9: fail fails
https://review.coreboot.org/c/coreboot/+/38666/17//COMMIT_MSG@9 PS17, Line 9: using "MAKEINFO = @MAKEINFO@", it fail to compile, so binutils-2.34_no-makeinfo.patch will change that to : "MAKEINFO = true" Please re-flow for 75 characters per line.
https://review.coreboot.org/c/coreboot/+/38666/17//COMMIT_MSG@11 PS17, Line 11: Did you report the build issue upstream, so the patch can be dropped when upgrading to the next release?
https://review.coreboot.org/c/coreboot/+/38666/17/util/crossgcc/patches/binu... File util/crossgcc/patches/binutils-2.34_no-makeinfo.patch:
https://review.coreboot.org/c/coreboot/+/38666/17/util/crossgcc/patches/binu... PS17, Line 1: diff --git binutils-2.34/Makefile.in binutils-2.34/Makefile.in It’d be nice to have a patch description – maybe even git formatted.