Joel Kitching has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43508 )
Change subject: libpayload: cbgfx: Add draw_line()
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/43508/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/43508/1//COMMIT_MSG@15
PS1, Line 15: depending on the value of
: pos_rel.y
By fixing draw_rounded_box(), we will have another issue: https://bugs.chromium. […]
Right -- thanks for the reminder.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43508
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2d50414c4bfed343516197da9bb50791c89ba4c2
Gerrit-Change-Number: 43508
Gerrit-PatchSet: 2
Gerrit-Owner: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: Joel Kitching
kitching@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 21 Jul 2020 02:29:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Joel Kitching
kitching@google.com
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Gerrit-MessageType: comment