Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35739 )
Change subject: soc/intel/common/block: Serialize microcode updates for HT threads
......................................................................
Patch Set 17:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35739/17/src/cpu/intel/microcode/mi...
File src/cpu/intel/microcode/microcode.c:
https://review.coreboot.org/c/coreboot/+/35739/17/src/cpu/intel/microcode/mi...
PS17, Line 63: Update just on the first CPU in the core.
That's not what's happening here, is it?
(I almost ran into the good old forgot-to-review-comments.)
Wouldn't it suffice to say that
* some HT capable CPUs need only one thread to do it,
* some need both threads and software-sync,
* some need both and do hardware-sync, and
* software sync'ed version always works!
?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35739
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I72804753e567a137a5648ca6950009fed332531b
Gerrit-Change-Number: 35739
Gerrit-PatchSet: 17
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-Comment-Date: Fri, 30 Oct 2020 21:31:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment