9 Nov
2019
9 Nov
'19
3:23 p.m.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36342 )
Change subject: sb/intel/common/spi: Add Baytrail/Braswell support ......................................................................
Patch Set 5: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/36342/5/src/southbridge/intel/commo... File src/southbridge/intel/common/spi.c:
https://review.coreboot.org/c/coreboot/+/36342/5/src/southbridge/intel/commo... PS5, Line 285: #ifdef __SIMPLE_DEVICE__ : pci_devfn_t dev = PCI_DEV(0, 31, 0); : #else : struct device *dev = pcidev_on_root(31, 0); : #endif Why not pass `dev` in instead?
--
To view, visit https://review.coreboot.org/c/coreboot/+/36342
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib14f185eab8bf708ad82b06c7a7ce586744318fd
Gerrit-Change-Number: 36342
Gerrit-PatchSet: 5
Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Frans Hendriks fhendriks@eltan.com
Gerrit-Comment-Date: Sat, 09 Nov 2019 23:23:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment