[coreboot-gerrit] Change in coreboot[master]: sio/winbond: Treat Immediate Power Down (IPD) as D3

[Nico Huber (Code Review)]

Hello Paul Menzel,

I'd like you to do a code review. Please visit

https://review.coreboot.org/c/coreboot/+/39746

to review the following change.

Change subject: sio/winbond: Treat Immediate Power Down (IPD) as D3
......................................................................

sio/winbond: Treat Immediate Power Down (IPD) as D3

Change-Id: Ifa28a7c56575848e76e4a1c542866413b4c44d50
Signed-off-by: Nico Huber 
---
M src/superio/winbond/w83627dhg/acpi/superio.asl
M src/superio/winbond/w83627hf/acpi/superio.asl
M src/superio/winbond/w83977tf/acpi/superio.asl
3 files changed, 10 insertions(+), 10 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/39746/1

diff --git a/src/superio/winbond/w83627dhg/acpi/superio.asl b/src/superio/winbond/w83627dhg/acpi/superio.asl
index cb6a4a7..f86f169 100644
--- a/src/superio/winbond/w83627dhg/acpi/superio.asl
+++ b/src/superio/winbond/w83627dhg/acpi/superio.asl
@@ -109,12 +109,12 @@
    #define PNP_EXIT_MAGIC_1ST	0xaa
    #include <superio/acpi/pnp_config.asl>

-	/* PM: indicate IPD (Immediate Power Down) bit state as D0/D2 */
+	/* PM: indicate IPD (Immediate Power Down) bit state as D0/D3 */
    Method (_PSC) {
    	ENTER_CONFIG_MODE (PNP_NO_LDN_CHANGE)
    	  Store (IPD, Local0)
    	EXIT_CONFIG_MODE ()
-		If (Local0) { Return (2) }
+		If (Local0) { Return (3) }
    	Else { Return (0) }
    }

@@ -125,8 +125,8 @@
    	EXIT_CONFIG_MODE ()
    }

-	/* PM: Switch to D2 by setting IPD high  */
-	Method (_PS2) {
+	/* PM: Switch to D3 by setting IPD high  */
+	Method (_PS3) {
    	ENTER_CONFIG_MODE (PNP_NO_LDN_CHANGE)
    	  Store (One, IPD)
    	EXIT_CONFIG_MODE ()
diff --git a/src/superio/winbond/w83627hf/acpi/superio.asl b/src/superio/winbond/w83627hf/acpi/superio.asl
index c1293ff..38791d3 100644
--- a/src/superio/winbond/w83627hf/acpi/superio.asl
+++ b/src/superio/winbond/w83627hf/acpi/superio.asl
@@ -166,12 +166,12 @@
    	Release (CRMX)
    }

-	/* PM: indicate IPD (Immediate Power Down) bit state as D0/D2 */
+	/* PM: indicate IPD (Immediate Power Down) bit state as D0/D3 */
    Method (_PSC) {
    	ENCM (0xFF)
    	Store (IPD, Local0)
    	EXCM ()
-		If (Local0) { Return (2) }
+		If (Local0) { Return (3) }
    	Else { Return (0) }
    }

@@ -182,8 +182,8 @@
    	EXCM ()
    }

-	/* PM: Switch to D2 by setting IPD high  */
-	Method (_PS2) {
+	/* PM: Switch to D3 by setting IPD high  */
+	Method (_PS3) {
    	ENCM (0xFF)
    	Store (One, IPD)
    	EXCM ()
diff --git a/src/superio/winbond/w83977tf/acpi/superio.asl b/src/superio/winbond/w83977tf/acpi/superio.asl
index e2ff2ef..c7a62cd 100644
--- a/src/superio/winbond/w83977tf/acpi/superio.asl
+++ b/src/superio/winbond/w83977tf/acpi/superio.asl
@@ -72,12 +72,12 @@
 #define PNP_EXIT_MAGIC_1ST      0xaa
 #include <superio/acpi/pnp_config.asl>

-/* PM: indicate IPD (Immediate Power Down) bit state as D0/D2 */
+/* PM: indicate IPD (Immediate Power Down) bit state as D0/D3 */
 Method (_PSC) {
    ENTER_CONFIG_MODE (0xFF)
    Store (IPD, Local0)
    EXIT_CONFIG_MODE ()
-	If (Local0) { Return (2) }
+	If (Local0) { Return (3) }
    Else { Return (0) }
 }