Brandon Breitenstein has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39459 )
Change subject: soc/intel/tigerlake: Configure IOM_TYPEC_SW_CONFIGURATUON_3
......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/39459/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/39459/2//COMMIT_MSG@9
PS2, Line 9: CONFIGURATUON
nit: CONFIGURATION? (also title line) […]
The EDS referenced at the end of the commit message explains this configuration
https://review.coreboot.org/c/coreboot/+/39459/2//COMMIT_MSG@10
PS2, Line 10: port 2
shouldn't this be […]
I will update the commit message this is able to control all the type-c port retimer enabled or disabled control
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39459
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iae356113cbdc72983f800060b1ebebe3c66b9daf
Gerrit-Change-Number: 39459
Gerrit-PatchSet: 2
Gerrit-Owner: Brandon Breitenstein
brandon.breitenstein@intel.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Georgi
pgeorgi@google.com
Gerrit-Comment-Date: Thu, 12 Mar 2020 22:39:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Georgi
pgeorgi@google.com
Comment-In-Reply-To: Caveh Jalali
caveh@chromium.org
Gerrit-MessageType: comment