Prashant Malani has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40024 )
Change subject: google/chromeec: Add USB MUX Interrupt ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40024/3/src/ec/google/chromeec/acpi... File src/ec/google/chromeec/acpi/ec.asl:
https://review.coreboot.org/c/coreboot/+/40024/3/src/ec/google/chromeec/acpi... PS3, Line 373: Notify (CREC, 0x80)
I wonder if it is better to do the following: […]
I chatted a bit with furquan@, and it seems like my suggestion may be the best path forward here for now.
Brandon, can you kindly do the following: - Incorporate the above change into this CL, and add a comment mentioning that this is a short-term solution while we transition to the PD notifier framework. - Try this CL with the kernel CLs I mentioned (which remove the LPCS hack and use the USBPD notifier).
I will also do the same. If we can verify that things work, then let's move ahead with the proposed solution.
I will also file a bug tracking this CL (we should remove it once the PD notifier stack and Type C connector class port driver are complete). WDYT?