Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37154 )
Change subject: Kconfig: Drop the C_ENVIRONMENT_BOOTBLOCK symbol ......................................................................
Patch Set 3:
(5 comments)
https://review.coreboot.org/c/coreboot/+/37154/1/src/cpu/intel/model_1067x/K... File src/cpu/intel/model_1067x/Kconfig:
https://review.coreboot.org/c/coreboot/+/37154/1/src/cpu/intel/model_1067x/K... PS1, Line 15: select SETUP_XIP_CACHE
Split, not strictly about flipping and should have been done before?
Done
https://review.coreboot.org/c/coreboot/+/37154/1/src/cpu/intel/model_6fx/Kco... File src/cpu/intel/model_6fx/Kconfig:
https://review.coreboot.org/c/coreboot/+/37154/1/src/cpu/intel/model_6fx/Kco... PS1, Line 16: select SETUP_XIP_CACHE
ditto
Done
https://review.coreboot.org/c/coreboot/+/37154/1/src/mainboard/facebook/fbg1... File src/mainboard/facebook/fbg1701/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/37154/1/src/mainboard/facebook/fbg1... PS1, Line 25: bootblock-y += com_init.c
ditto
Done
https://review.coreboot.org/c/coreboot/+/37154/1/src/mainboard/portwell/m107... File src/mainboard/portwell/m107/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/37154/1/src/mainboard/portwell/m107... PS1, Line 18: bootblock-y += com_init.c
ditto
Done
https://review.coreboot.org/c/coreboot/+/37154/1/src/vendorcode/eltan/securi... File src/vendorcode/eltan/security/verified_boot/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/37154/1/src/vendorcode/eltan/securi... PS1, Line 20: ifneq ($(CONFIG_ROMCC_BOOTBLOCK),y)
Do you need the conditional here? While built, it will not get linked.
Done