Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36286 )
Change subject: soc/mediatek/mt8183: Pass MR values as function arguments
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36286/2/src/soc/mediatek/mt8183/dra...
File src/soc/mediatek/mt8183/dramc_init_setting.c:
https://review.coreboot.org/c/coreboot/+/36286/2/src/soc/mediatek/mt8183/dra...
PS2, Line 758: 0x26 & 0x8f;
this results in 0x6. Shuold we just put that instead of the 0x26 & 0x8f? […]
Found in mt8183-dramk-private: "Other vendors: Use default MR01 for each FSP". I think the initial values are useless here.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36286
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id21483092c86c3ae7dbb1173a2b943defe41a379
Gerrit-Change-Number: 36286
Gerrit-PatchSet: 2
Gerrit-Owner: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: Huayang Duan
huayang.duan@mediatek.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: huayang duan
huayangduan@gmail.com
Gerrit-Comment-Date: Thu, 24 Oct 2019 08:24:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hung-Te Lin
hungte@chromium.org
Gerrit-MessageType: comment